Skip to content

✨ Add support for installing bundles with webhooks #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

Description

Depends on #1893

Adds webhook support to bundle renderer with certificate management. Based on Joe's PoC #1506

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Per Goncalves da Silva added 2 commits April 11, 2025 14:27
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 94e5940
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67f94122fb339a000846e418
😎 Deploy Preview https://deploy-preview-1914--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva changed the title Add wh support ✨ Add support for bundles with webhooks Apr 11, 2025
@perdasilva perdasilva changed the title ✨ Add support for bundles with webhooks ✨ Add support for installing bundles with webhooks Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 91.44812% with 75 lines in your changes missing coverage. Please review.

Project coverage is 71.47%. Comparing base (ed205c5) to head (94e5940).

Files with missing lines Patch % Lines
...-controller/rukpak/render/generators/generators.go 89.56% 23 Missing and 13 partials ⚠️
...operator-controller/rukpak/util/testing/testing.go 0.00% 14 Missing ⚠️
internal/operator-controller/rukpak/util/util.go 27.77% 13 Missing ⚠️
...troller/rukpak/render/certproviders/certmanager.go 88.60% 4 Missing and 5 partials ⚠️
...ternal/operator-controller/rukpak/render/render.go 93.75% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
+ Coverage   69.51%   71.47%   +1.96%     
==========================================
  Files          68       74       +6     
  Lines        5357     5971     +614     
==========================================
+ Hits         3724     4268     +544     
- Misses       1401     1454      +53     
- Partials      232      249      +17     
Flag Coverage Δ
e2e 46.98% <36.50%> (-3.72%) ⬇️
unit 60.47% <89.85%> (+3.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant