-
Notifications
You must be signed in to change notification settings - Fork 62
🌱 Bump mkdocs to 1.6.0 and mkdocs-material to 9.5.19 #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Per Goncalves da Silva <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 67.21% 67.21%
=======================================
Files 23 23
Lines 1467 1467
=======================================
Hits 986 986
Misses 415 415
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -1 +1 @@ | |||
mkdocs-material==9.5.18 | |||
mkdocs-material==9.5.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need requirements.txt
in root? With a quick grep I do not see how it is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like a partial duplicate of docs/requirements.txt
. I think we can get rid of duplicated requirements by adding base = "docs"
into netlify.toml
.
I think I'm ok with merging this PR as is as it is not in scope for dependency bump.
Description
Merges dependabot PRs: #787 and #773
Reviewer Checklist