Skip to content

Commit 2dd27bd

Browse files
authored
Fix release automation (#3429)
Currently two release drafts are being created. We want one draft to be created by goreleaser and we want softprops/action-gh-release GitHub action to append artifacts into the existing release. Since goreleaser creates a draft anyway it seems like "Create a draft release" is not necessary. Signed-off-by: Mikalai Radchuk <[email protected]>
1 parent fb6694f commit 2dd27bd

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

.github/workflows/goreleaser.yaml

+4-10
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,6 @@ jobs:
2727
echo IMAGE_TAG="snapshot" >> $GITHUB_ENV
2828
fi
2929
30-
- name: Create a draft release
31-
uses: softprops/action-gh-release@v2
32-
id: release
33-
if: startsWith(github.ref, 'refs/tags')
34-
env:
35-
GITHUB_TOKEN: ${{ github.token }}
36-
with:
37-
name: ${{ env.IMAGE_TAG }}
38-
draft: true
39-
4030
- name: Set up QEMU
4131
uses: docker/setup-qemu-action@v3
4232

@@ -58,6 +48,10 @@ jobs:
5848
IMAGE_REPO: quay.io/operator-framework/olm
5949
PKG: github.com/operator-framework/operator-lifecycle-manager
6050

51+
# The below steps depend on a image being present in a image registry
52+
# as well as existence of a release on GitHub which are not
53+
# being created by goreleaser when run against anything other than a tag.
54+
# So we only run the steps below for tags.
6155
- name: Generate quickstart release manifests
6256
if: startsWith(github.ref, 'refs/tags')
6357
run: make release RELEASE_VERSION=${{ env.IMAGE_TAG }} IMAGE_REPO=quay.io/operator-framework/olm

0 commit comments

Comments
 (0)