Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release automation #3429

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix release automation #3429

merged 1 commit into from
Nov 4, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 1, 2024

Description of the change:

We want one draft to be created by goreleaser
and we want softprops/action-gh-release GitHub action to append artifacts into the existing release.

Since goreleaser creates a draft anyway it seems like "Create a draft release" is not necessary.

Motivation for the change:

Currently two release drafts are being created.

Architectural changes:

Changing release tooling only.

Testing remarks:

Need to push a tag

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Fix release automation
3051d30 
Currently two release drafts are being created.
We want one draft to be created by goreleaser
and we want softprops/action-gh-release GitHub action
to append artifacts into the existing release.

Since goreleaser creates a draft anyway it seems like
"Create a draft release" is not necessary.

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot requested review from benluddy and dtfranz November 1, 2024 16:28
@perdasilva perdasilva added this pull request to the merge queue Nov 4, 2024
Merged via the queue into operator-framework:master with commit 2dd27bd Nov 4, 2024
12 checks passed
@m1kola m1kola mentioned this pull request Nov 4, 2024
Closed
@m1kola m1kola deleted the fix_release_automation branch November 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perdasilva perdasilva perdasilva approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1kola @perdasilva