Support ConsoleYamlSample in bundle manifests

[Jamstah]

Feature Request

Is your feature request related to a problem? Please describe.
I would like to add ConsoleYamlSamples to my operator, but at the moment, I have to run an init hook in my operator pod to install them into the cluster

Describe the solution you'd like
Be able to drop ConsoleYamlSamples into the bundle manifests directory and have them applied to the cluster.

I did try this, and get UnsupportedResource on the InstallPlan

    - resolving: ibm-integration-platform-navigator.v4.0.1
      resource:
        group: console.openshift.io
        kind: ConsoleYAMLSample
        manifest: >
          {"apiVersion":"console.openshift.io/v1","kind":"ConsoleYAMLSample","metadata":{"name":"pn-sample-1"},"spec":{"description":"PN
          Sample","snippet":false,"targetResource":{"apiVersion":"integration.ibm.com/v1beta1","kind":"PlatformNavigator"},"title":"Sample
          1","yaml":"---\napiVersion: integration.ibm.com/v1beta1\nkind:
          PlatformNavigator\nmetadata:\n    name: cp4i-navigator\n    namespace:
          cp4i\nspec:\n    license:\n        accept: true\n    mqDashboard:
          true\n    replicas: 3\n    version: 2020.2.1\n"}}
        name: pn-sample-1
        sourceName: pn
        sourceNamespace: openshift-marketplace
        version: v1
      status: UnsupportedResource

[exdx]

We are adding supporting to additional objects to the operator bundle and potentially expanding the scope to all arbitrary kube objects at some point in the future. I think this is a valid feature request and we can hopefully accommodate it in a future release of OLM.

[Jamstah]

@exdx Thanks. I've actually submitted a PR that's currently sitting waiting. What are the next steps to get that merged?

[exdx]

Looks like @ecordell approved it so I went ahead and gave it an lgtm so its pretty much good to go. We are currently in feature freeze, so master isn't open, but your PR will merge when master opens back up in several weeks.

[exdx]

@Jamstah note: your PR adds support for ConsoleYamlSample types in OLM, but we would also need to support adding this type to operator bundles, otherwise a bundle with a ConsoleYamlSample would fail validation by opm.

See https://github.com/exdx/operator-registry/blob/master/pkg/lib/bundle/supported_resources.go for the file that should be updated

[Jamstah]

Thanks for spotting that, I had seen it before and thought it was sensible to add it here first, then into opm, so that we don't end up with packages that have unsupported resources. I had since forgotten about it though :)

Have opened that PR too now:

• operator-lifecycle-manager: Allow ConsoleYAMLSample resources from bundle manifests #1616
• operator-registry: Add ConsoleYamlSamples to the supported resources operator-registry#432

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.