Skip to content

Namespace resolution should error out if catalog cache can't be populated #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benluddy opened this issue Jul 23, 2021 · 0 comments · Fixed by #2290
Closed

Namespace resolution should error out if catalog cache can't be populated #2288

benluddy opened this issue Jul 23, 2021 · 0 comments · Fixed by #2290
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@benluddy
Copy link
Contributor

If

operator-lifecycle-manager/pkg/controller/registry/resolver/cache.go

Line 197 in 86998b0

snapshot.logger.Errorf("failed to list bundles: %s", err.Error())
happens, all of the content from that catalog is ignored. This either generates confusing messages or makes a surprising resolution decision.

Better to fail outright with a clear error message naming the CatalogSource in question.
@benluddy benluddy added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2021
@benluddy benluddy linked a pull request Jul 26, 2021 that will close this issue
Expose errors generated while retrieving catalog content. #2290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose errors generated while retrieving catalog content. benluddy/operator-lifecycle-manager
1 participant
@benluddy