Expose errors generated while retrieving catalog content. #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Failing to fetch catalog content should not silently return an empty cache. Instead, it should fail outright with an error that indicates which catalog(s) could not be fetched. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
resolver-cache-catalog-error
branch
from
a49cd8b to
6ab5f16
Compare
ecordell
reviewed
Jul 26, 2021
| @@ -8,6 +8,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "k8s.io/apimachinery/pkg/util/errors" | |||
|
|
|||
| defer func() { | ||
| // Don't cache an errorred snapshot. | ||
| if snapshot.err != nil { | ||
| snapshot.expiry = time.Time{} |
There was a problem hiding this comment.
does this trigger a cache-refresh hotloop?
There was a problem hiding this comment.
At worst I'd expect syncResolvingNamespace to be requeued a handful of times, but that's a flat number of retries, not a feedback cycle. Do you have a particular cycle in mind that I missed?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to fetch catalog content should not silently return an empty
cache. Instead, it should fail outright with an error that indicates
which catalog(s) could not be fetched.