-
Notifications
You must be signed in to change notification settings - Fork 552
End-to-end test binary can set up test clusters #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 1 commit into
operator-framework:master
from
benluddy:e2e-go
Apr 2, 2020
+38,974
−11,491
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| apiVersion: v2 | ||
| description: A Helm chart for Kubernetes | ||
| name: olm | ||
| version: 0.0.0-dev | ||
91 changes: 0 additions & 91 deletions
91
deploy/chart/templates/e2e-local-01-openshift-config-proxy-crd.yaml
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
deploy/chart/templates/e2e-local-02-openshift-cluster-proxy-cr.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,5 @@ | ||
| FROM golang:1.10 as builder | ||
| LABEL stage=builder | ||
| WORKDIR /go/src/github.com/operator-framework/operator-lifecycle-manager | ||
| RUN curl -L https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 -o /bin/jq | ||
| RUN chmod +x /bin/jq | ||
| # copy just enough of the git repo to parse HEAD, used to record version in OLM binaries | ||
| COPY .git/HEAD .git/HEAD | ||
| COPY .git/refs/heads/. .git/refs/heads | ||
| RUN mkdir -p .git/objects | ||
| COPY Makefile Makefile | ||
| COPY OLM_VERSION OLM_VERSION | ||
| COPY pkg pkg | ||
| COPY vendor vendor | ||
| COPY cmd cmd | ||
| COPY test test | ||
| RUN make build-coverage | ||
|
|
||
| FROM alpine:latest as olm | ||
| LABEL stage=olm | ||
| WORKDIR / | ||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/olm /bin/olm | ||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/catalog /bin/catalog | ||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/package-server /bin/package-server | ||
| FROM scratch | ||
| COPY olm catalog package-server wait cpb /bin/ | ||
| EXPOSE 8080 | ||
| EXPOSE 5443 | ||
| CMD ["/bin/olm"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this description verbose enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the original description from 2017. If we decide to include the chart as part of the release (as opposed to only using it for templating internally) then it should definitely be improved, but I don't think it needs to be touched as part of this PR.