Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example YAMLs #2

Closed
wants to merge 1 commit into from
Closed

Example YAMLs #2

wants to merge 1 commit into from

Conversation

alecmerdler
Copy link
Member

@alecmerdler alecmerdler commented Aug 22, 2017

Implementations of the concepts in the current proposal. Includes AppType, Operator and app CRDs.

Create CRD in running cluster:
kubectl create -f <file>

@alecmerdler alecmerdler requested a review from jakedt August 22, 2017 19:19
@@ -0,0 +1,15 @@
apiVersion: apiextensions.k8s.io/v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we're not putting Affordances in our first proposal, unless you are hereby voting for them and pitching them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, removed.

plural: mysqls
singular: mysql
kind: MySQL
schema: "TODO"
Copy link
Contributor

@jakedt jakedt Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema properties should be under spec, like so:

spec:
  validation:
    openAPISpecV3:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add them back in with a TODO for the actual schema?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

plural: mysqls
singular: mysql
kind: MySQL
schema: TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this one too.

@alecmerdler alecmerdler deleted the example-yamls branch August 31, 2017 19:01
openshift-merge-robot added a commit that referenced this pull request Jan 29, 2019
Write cluster operator status after successful startup (attempt #2)
ecordell referenced this pull request in ecordell/operator-lifecycle-manager Mar 8, 2019
Write cluster operator status after successful startup (attempt #2)
ecordell pushed a commit that referenced this pull request Aug 21, 2019
[doc] Add fake README to the project proposal
@asmacdo asmacdo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants