Bug 1945261: Fix inconsistent dependency candidate order. #2068
Conversation
openshift-ci-robot
added
the
approved
|
/hold There should be a regression test for this. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
benluddy
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@benluddy: This pull request references Bugzilla bug 1945261, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
benluddy
force-pushed
the
inconsistent-candidate-order-with-csv-in-two-channels
branch
from
17e3a4a to
da54924
Compare
After bundle dependency candidates are sorted, a second query is made to the catalog cache. This query filters by CSV name alone, so it's ambiguous when the same CSV name appears in multiple channels (or packages). The query appears to be redundant, so it has been removed. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
inconsistent-candidate-order-with-csv-in-two-channels
branch
from
da54924 to
f749c5a
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/cherry-pick release-4.7 |
|
@benluddy: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1945261 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@benluddy: new pull request created: #2072 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After bundle dependency candidates are sorted, a second query is made
to the catalog cache. This query filters by CSV name alone, so it's
ambiguous when the same CSV name appears in multiple channels (or
packages). The query appears to be redundant, so it has been removed.