Use DeploymentAvailable instead of custom test for CSV status. #2125
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
benluddy
force-pushed
the
csv-deployment-availability
branch
from
6f61f00 to
fe8cd06
Compare
CSVs can transition to Failed (reason ComponentUnhealthy) if a single pod managed by one of its deployments is deleted. This commit changes the deployment availability test from a comparison between .status.availableReplicas and .status.updatedReplicas to a check that passes unless the deployment's Available condition exists and is False. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
csv-deployment-availability
branch
from
fe8cd06 to
929fa8b
Compare
|
/lgtm |
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/cherry-pick release-4.7 |
|
@benluddy: new pull request created: #2150 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CSVs can transition to Failed (reason ComponentUnhealthy) if a single
pod managed by one of its deployments is deleted. This commit changes
the deployment availability test from a comparison between
.status.availableReplicas and .status.updatedReplicas to a check that
passes unless the deployment's Available condition exists and is
False.
Prospective upstream fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1945443