Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CR validation bug on go 1.16 #2136

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix CR validation bug on go 1.16 #2136

merged 2 commits into from
May 4, 2021

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented May 4, 2021 •
edited
Loading

See kubernetes/kube-openapi#230 for details

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@ecordell ecordell changed the title Add unit test showing cr validation bug Fix CR validation bug May 4, 2021
@ecordell
Copy link
Member Author

ecordell commented May 4, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
dinhxuanvu
dinhxuanvu approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell ecordell changed the title Fix CR validation bug Fix CR validation bug on go 1.16 May 4, 2021
@timflannagan
Copy link
Member

/skip

@njhale
Copy link
Member

njhale commented May 4, 2021

/override ci/prow/images

@openshift-ci-robot
Copy link
Collaborator

@njhale: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/images

Only the following contexts were expected:

  • tide

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member

njhale commented May 4, 2021

/override tide

@openshift-ci-robot
Copy link
Collaborator

@njhale: Overrode contexts on behalf of njhale: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 02d278b into operator-framework:master May 4, 2021
@ecordell ecordell mentioned this pull request May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunrn arjunrn arjunrn left review comments

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@njhale njhale Awaiting requested review from njhale

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ecordell @openshift-ci-robot @openshift-bot @timflannagan @njhale @arjunrn @dinhxuanvu @openshift-merge-robot