Remove component adoption labels before initial CSV copy. #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
benluddy
force-pushed
the
copied-csv-adoption-flake
branch
from
d5dd67d to
a5890d4
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
benluddy
force-pushed
the
copied-csv-adoption-flake
branch
from
a5890d4 to
6959fe2
Compare
|
/hold Looking into a test failure that looks related:
|
openshift-ci
bot
added
the
do-not-merge/hold
dinhxuanvu
approved these changes
May 18, 2021
benluddy
force-pushed
the
copied-csv-adoption-flake
branch
from
6959fe2 to
bfb97a4
Compare
Operator component labels were not being stripped before initially creating a CSV copy (they were only being stripped on subsequent updates to copies). Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
copied-csv-adoption-flake
branch
from
bfb97a4 to
7a63093
Compare
|
/hold cancel Should be resolved now -- the cache-get is load-bearing and has to stay. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator component labels were not being stripped before initially
creating a CSV copy (they were only being stripped on subsequent
updates to copies).
This explains why the end-to-end test for copied CSV adoption has been failing sporadically.