Check for conflicting install #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
reviewed
Jun 8, 2021
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
benluddy
reviewed
Jun 8, 2021
scripts/install.sh
Outdated
| @@ -14,6 +14,12 @@ if [[ ${#@} -lt 1 || ${#@} -gt 2 ]]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| openshift_install_check=$(kubectl get deployment olm-operator -n openshift-operator-lifecycle-manager -o=jsonpath='{.spec}' 2>/dev/null) | |||
There was a problem hiding this comment.
Is the string test necessary? kubectl get should exit with a nonzero status code if it doesn't find the resource, IIRC.
Update the install script so that known conflicting downstream installations of OLM don't cause conflicts and hotloop
kevinrizza
force-pushed
the
install-script-update
branch
from
3497563 to
d7eead7
Compare
joelanford
reviewed
Jun 8, 2021
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
I think we can fix this via my suggestion here: #2210 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the install script so that known conflicting downstream installations of OLM don't cause conflicts and hotloop