Explain unique replaces chain requirement in channel sort errors. #2260
Conversation
benluddy
force-pushed
the
name-multiple-replaces-chains
branch
from
9df7885 to
0de3fd4
Compare
openshift-ci
bot
added
the
approved
|
/hold This is a WIP, and may have also identified a bug with one of the new tests. |
openshift-ci
bot
added
the
do-not-merge/hold
benluddy
force-pushed
the
name-multiple-replaces-chains
branch
from
0de3fd4 to
a2ca9b0
Compare
benluddy
force-pushed
the
name-multiple-replaces-chains
branch
from
a2ca9b0 to
4822746
Compare
The "multiple channel head" error that can be returned from channel sorting has been a source of confusion for users. The error message now explains that a unique replacement chain is required in order to define the relative order between channel entries, and it also provides an abbreviated list of all replacement chains identified, in the form "head...tail" or "singleton". Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
name-multiple-replaces-chains
branch
from
4822746 to
6391025
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
| } | ||
|
|
||
| // TODO: do we care if the channel doesn't include every bundle in the input? | ||
| if len(chains) == 0 { | ||
| // Bug? |
There was a problem hiding this comment.
programmer error if we hit this
| "packageB.v1": genOperator("packageB.v1", "1.0.0", "", "packageB", "alpha", "community", "olm", nil, nil, nil, "", false), | ||
| } | ||
| assert.Equal(t, 2, len(operators)) | ||
| assert.Len(t, operators, 1) |
There was a problem hiding this comment.
discussed offline: this change confused me, but the old assertions were incorrect because packageA.v1 replaced itself
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@benluddy @kevinrizza Will it be cherry-picked to the downstream repo? If yes, when? I checked the latest commits(1dc76f0) of the downstream repo, but not found this PR. I am really interested in the process of picking up upstream PRs for the downstream. Could you help explain more about it? Or any doc? Thanks! |
The "multiple channel head" error that can be returned from channel
sorting has been a source of confusion for users. The error message
now explains that a unique replacement chain is required in order to
define the relative order between channel entries, and it also
provides an abbreviated list of all replacement chains identified, in
the form "head...tail" or "singleton".