-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary and description for prometheus alerts #2361
Add summary and description for prometheus alerts #2361
Conversation
d6c0815
to
52129ff
Compare
Signed-off-by: Tyler Slaton <[email protected]>
Signed-off-by: Tyler Slaton <[email protected]>
pkg/controller/operators/catalog/testdata/prometheusrule.cr.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tyler Slaton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add any tests that ensure this behavior for any of the metrics present in that PrometheusRule resource in the e2e suite to ensure we don't regress?
/lgtm
It wouldn't hurt to have a test case that checks that those alerts fire when we expect and adhere to the standards linked above (with the summary and description being present). That would also make sure, like you said, that we don't remove this in the future. |
@tylerslaton: All pull requests linked via external trackers have merged: Bugzilla bug 1992510 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Removing "Bug 1992510:" as this is the upstream repository and automation will pick up this PR and move it into the incorrect state. |
Description of the change:
Adding a summary annotation and replace the message annotation with description for prometheus alerts.
Motivation for the change:
Fixing Bug 1992510 which references the Open Shift alerting standards.
Reviewer Checklist
/doc