chore(make): add e2e test options #2393
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -22,5 +22,5 @@ jobs: | |||
| run: | | |||
| kind create cluster | |||
| kind export kubeconfig | |||
| - name: Run e2e tests | |||
There was a problem hiding this comment.
These aren't really running e2e tests so much as they're ensuring we can deploy OLM to a specific target; how valuable is this?
There was a problem hiding this comment.
I had previously attempted to remove these checks entirely but there was some pushback in #olm-dev as they're mainly in place to ensure there's no regression when running OLM on various cluster environments.
There was a problem hiding this comment.
But for context, I had renamed this check and simply misjudged what these checks were trying to accomplish when splitting up that e2e-tests GHA workflow into their own workflows.
| E2E_INSTALL_NS ?= operator-lifecycle-manager | ||
| E2E_TEST_NS ?= operators |
There was a problem hiding this comment.
Reminder: we need to set the downstream-specific namespaces in the root Makefile downstream before invoking this target; e.g. E2E_INSTALL_NS=openshift-operator-lifecycle-manager E2E_TEST_NS=openshift-operators $(MAKE) ...
|
/lgtm |
|
|
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
Hold so the bot doesn't go crazy. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
- Add more config options to the e2e and e2e-local test options; e.g. E2E_TEST_SEED for reproducing test runs - Refactor e2e-local target to extend the e2e target Signed-off-by: Nick Hale <[email protected]>
|
/lgtm |
E2E_TEST_SEED for reproducing test runs
Signed-off-by: Nick Hale [email protected]