Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: use v1 PDB in e2e bundle test #2398

Merged

Conversation

exdx
Copy link
Member

@exdx exdx commented Oct 5, 2021

Signed-off-by: Daniel Sover [email protected]

Description of the change:
Changes the version of the PDB object in the bundle to v1 since v1beta1 PDBs were deprecated in 1.21.

Motivation for the change:
Flaky test

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@@ -54,7 +54,7 @@ var _ = Describe("Installing bundles with new object types", func() {
By("first installing the VPA CRD on cluster")
const (
sourceName = "test-catalog"
imageName = "quay.io/olmtest/single-bundle-index:pdb"
imageName = "quay.io/olmtest/single-bundle-index:pdb-v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be awesome if we'd eventually be able to house and make directy modifications to static bundle/index images as text fixtures in-tree vs. we update the index images whenever we run into issues (e.g. k8s 1.22 API updates).

/lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agreed. We've wanted that ability for a long time for our e2e tests and looks like with DC we will finally be able to do that, which is great

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4c3c8f1 into operator-framework:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants