-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: use v1 PDB in e2e bundle test #2398
test/e2e: use v1 PDB in e2e bundle test #2398
Conversation
Signed-off-by: Daniel Sover <[email protected]>
@@ -54,7 +54,7 @@ var _ = Describe("Installing bundles with new object types", func() { | |||
By("first installing the VPA CRD on cluster") | |||
const ( | |||
sourceName = "test-catalog" | |||
imageName = "quay.io/olmtest/single-bundle-index:pdb" | |||
imageName = "quay.io/olmtest/single-bundle-index:pdb-v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be awesome if we'd eventually be able to house and make directy modifications to static bundle/index images as text fixtures in-tree vs. we update the index images whenever we run into issues (e.g. k8s 1.22 API updates).
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, agreed. We've wanted that ability for a long time for our e2e tests and looks like with DC we will finally be able to do that, which is great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Daniel Sover [email protected]
Description of the change:
Changes the version of the PDB object in the bundle to v1 since v1beta1 PDBs were deprecated in 1.21.
Motivation for the change:
Flaky test
Reviewer Checklist
/doc