Skip to content

Makefile: Update the e2e-local target and add CI-friendly ginkgo options #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

Makefile: Update the e2e-local target and add CI-friendly ginkgo options #2414

merged 1 commit into from
Oct 13, 2021

Conversation

timflannagan
Copy link
Member

Update the root Makefile's e2e-local target and add the
--randomizeSuites, --race, --trace, and --progress flags to increase
debugging failed CI attempts.

Signed-off-by: timflannagan [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from hasbro17 and kevinrizza October 8, 2021 01:51
@timflannagan timflannagan force-pushed the expand-ginkgo-makefile-ci-options branch 3 times, most recently from a81481c to f543a6a Compare October 8, 2021 16:32
njhale
njhale approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the race detector helps us too much (since our controllers are running out-of-process), but I don't think it will hurt us.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@timflannagan timflannagan force-pushed the expand-ginkgo-makefile-ci-options branch from f543a6a to 3917625 Compare October 8, 2021 23:25
@timflannagan
Copy link
Member Author

#2411 - going to rebase against master.
#2408
#2417

This looks like a new one:

2021-10-08T23:51:35.7865233Z �[91m�[1m• Failure [308.131 seconds]�[0m
2021-10-08T23:51:35.7865981Z Catalog represents a store of bundles which OLM can use to install Operators
2021-10-08T23:51:35.7867602Z �[90m/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:35�[0m
2021-10-08T23:51:35.7869085Z   �[91m�[1mdelete internal registry pod triggers recreation [It]�[0m
2021-10-08T23:51:35.7870595Z   �[90m/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:514�[0m
2021-10-08T23:51:35.7871521Z 
2021-10-08T23:51:35.7871991Z   �[91m
2021-10-08T23:51:35.7872431Z   	Error Trace:	util_test.go:101
2021-10-08T23:51:35.7873004Z   	            				catalog_e2e_test.go:571
2021-10-08T23:51:35.7873519Z   	            				runner.go:113
2021-10-08T23:51:35.7874009Z   	            				runner.go:64
2021-10-08T23:51:35.7874494Z   	            				it_node.go:26
2021-10-08T23:51:35.7874950Z   	            				spec.go:215
2021-10-08T23:51:35.7875416Z   	            				spec.go:138
2021-10-08T23:51:35.7875900Z   	            				spec_runner.go:200
2021-10-08T23:51:35.7876431Z   	            				spec_runner.go:170
2021-10-08T23:51:35.7877182Z   	            				spec_runner.go:66
2021-10-08T23:51:35.7877681Z   	            				suite.go:79
2021-10-08T23:51:35.7878167Z   	            				ginkgo_dsl.go:238
2021-10-08T23:51:35.7878649Z   	            				ginkgo_dsl.go:221
2021-10-08T23:51:35.7879143Z   	            				e2e_test.go:57
2021-10-08T23:51:35.7879708Z   	Error:      	Received unexpected error:
2021-10-08T23:51:35.7880372Z   	            	timed out waiting for the condition
2021-10-08T23:51:35.7881408Z   	Test:       	Catalog represents a store of bundles which OLM can use to install Operators delete internal registry pod triggers recreation
2021-10-08T23:51:35.7882450Z   �[0m
2021-10-08T23:51:35.7882701Z 
2021-10-08T23:51:35.7884181Z   /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1231
2021-10-08T23:51:35.7885230Z 
2021-10-08T23:51:35.7885791Z   �[91mFull Stack Trace�[0m
2021-10-08T23:51:35.7886600Z   github.com/stretchr/testify/require.NoError(0x7f3b083483b8, 0xc000199e00, 0x36b9460, 0xc000206730, 0x0, 0x0, 0x0)
2021-10-08T23:51:35.7888505Z   	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1231 +0xcb
2021-10-08T23:51:35.7890879Z   github.com/operator-framework/operator-lifecycle-manager/test/e2e.awaitPods(0x373bac8, 0xc000199e00, 0x374d0c0, 0xc000af61b0, 0x7ffe6e447e8d, 0x9, 0xc002477080, 0x1f, 0xc002509d60, 0xc0005a9030, ...)
2021-10-08T23:51:35.7918154Z   	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:101 +0x1c5
2021-10-08T23:51:35.7920027Z   github.com/operator-framework/operator-lifecycle-manager/test/e2e.glob..func2.8()
2021-10-08T23:51:35.7921817Z   	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:571 +0xeeb
2021-10-08T23:51:35.7923543Z   github.com/operator-framework/operator-lifecycle-manager/test/e2e.TestEndToEnd(0xc0005cf380)
2021-10-08T23:51:35.7925296Z   	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/e2e_test.go:57 +0x276
2021-10-08T23:51:35.7926385Z   testing.tRunner(0xc0005cf380, 0x3439610)
2021-10-08T23:51:35.7927127Z   	/opt/hostedtoolcache/go/1.16.8/x64/src/testing/testing.go:1193 +0xef
2021-10-08T23:51:35.7927784Z   created by testing.(*T).Run
2021-10-08T23:51:35.7928468Z   	/opt/hostedtoolcache/go/1.16.8/x64/src/testing/testing.go:1238 +0x2b3
2021-10-08T23:51:35.7929278Z �[90m------------------------------�[0m
2021-10-08T23:52:40.0504696Z �[0mOperator Group�[0m 
2021-10-08T23:52:40.0505965Z   �[1mintersection�[0m
2021-10-08T23:52:40.0507756Z   �[37m/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/operator_groups_e2e_test.go:816�[0m
...
[Fail] Catalog represents a store of bundles which OLM can use to install Operators [It] delete internal registry pod triggers recreation 
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1231

@timflannagan timflannagan mentioned this pull request Oct 11, 2021
Open
@exdx
Copy link
Member

exdx commented Oct 11, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Member Author

timflannagan commented Oct 11, 2021 •
edited
Loading

#2405
#2417
#2408

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Member Author

#2409

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Makefile: Update the e2e-local target and add CI-friendly ginkgo options
6ede0f7 
Update the root Makefile's `e2e-local` target and add the
--randomizeSuites, --race, --trace, and --progress flags to increase
debugging failed CI attempts.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the expand-ginkgo-makefile-ci-options branch from 3917625 to 6ede0f7 Compare October 13, 2021 14:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2021

New changes are detected. LGTM label has been removed.

@timflannagan timflannagan added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@timflannagan
Copy link
Member Author

Re-adding the lgtm label: rebased against master since Alex's PR for removing some frequent flakes has landed in master.

@openshift-merge-robot openshift-merge-robot merged commit 74e0a4c into operator-framework:master Oct 13, 2021
@timflannagan timflannagan deleted the expand-ginkgo-makefile-ci-options branch October 13, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timflannagan @exdx @openshift-bot @njhale @openshift-merge-robot