-
Notifications
You must be signed in to change notification settings - Fork 551
Fix the subscription annotation #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
generating invalid metadata.Labels for an already adopted Subscription resource Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba: This pull request references Bugzilla bug 2016425, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @SchSeba. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SchSeba The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I test it on my env without any errors
|
@SchSeba: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Removed ocp bug prefix, since this is the upstream repository |
@kevinrizza is the failing a flake? or something my PR breaks |
Hi @dinhxuanvu @timflannagan any update on this PR? |
@SchSeba Apologies for the slow replies - our upstream e2e runs have been fairly red this past month, so that's been our focus. I can take a look at these changes today. |
Hi @timflannagan any update on this PR? do you want me to close it if you think is not necessary ? |
Closing in favor of #2731 |
generating invalid metadata.Labels for an already adopted Subscription resource
Signed-off-by: Sebastian Sch [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc