.github/workflows: Update the checkouts action to use the v1 version #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update any relevant workflows and downgrade the checkouts action from the v2 to v1 version. This change is predicated on the problematic checkouts@v2 behavior that can lead to an increased change of regressing when landing changes to the default branch (e.g. master/main). This is because there's an existing bug in the v2 world where PRs can checkout the wrong HEAD commit, leading to scenarios where you're testing against an out-of-date commit compared to what's in the master branch. A concrete use case is when a PR is opened, and that PR checks out the current HEAD commit from master, and then a change lands in the master branch, and any subsequent workflow retries for that PR will result in that previous HEAD commit being checked out. There are workarounds that exist, like rebasing the existing PR, or like explicitly pointing the ref to the default branch, but this interaction isn't ideal with workflows are triggered on pushes to branches on top of reacting to pull request triggers. The simplest solution is to revert back to the v1 version and find a better longer term solution. Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
ci/use-checkouts-action-v1-version
branch
from
350c8a2 to
4d6bb35
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update any relevant workflows and downgrade the checkouts action from
the v2 to v1 version. This change is predicated on the problematic
checkouts@v2 behavior that can lead to an increased change of regressing
when landing changes to the default branch (e.g. master/main). This is
because there's an existing bug in the v2 world where PRs can checkout
the wrong HEAD commit, leading to scenarios where you're testing against
an out-of-date commit compared to what's in the master branch.
A concrete use case is when a PR is opened, and that PR checks out the
current HEAD commit from master, and then a change lands in the master
branch, and any subsequent workflow retries for that PR will result in
that previous HEAD commit being checked out. There are workarounds that
exist, like rebasing the existing PR, or like explicitly pointing the
ref to the default branch, but this interaction isn't ideal with workflows
are triggered on pushes to branches on top of reacting to pull request
triggers. The simplest solution is to revert back to the v1 version and
find a better longer term solution.
Signed-off-by: timflannagan [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc