Fix e2e Subscription - creation with pod config [It] fails intermittently

[akihikokuroda]

Signed-off-by: akihikokuroda [email protected]

Description of the change:

Use the copy of deployments in checkForDeployments function in /pkg/controller/install/deployment.go.
It prevent that the hash value of the cached deployment is changed unexpectedly.

Motivation for the change:

Once the value is changed, the changed value that is different from the actual instance in the cluster is returned by the lister calls.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

Closes #2507

[openshift-ci]

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dinhxuanvu]

/ok-to-test

[dinhxuanvu]

Looking good
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timflannagan]

Thanks!

/lgtm

[timflannagan]

Weirdly enough, it looks like we do a poor job of cleaning up these resources once the test case has passed. There's ~4 Operator resources that are still present locally when isolating this test, so we'd need to remove the generated CRDs first, then remove any Operator resources that were generated by the controller to avoid re-creation. We don't have to tackle fixing this here, but just wanted to make the note before I move onto other work.