test/e2e: Support logging individual resources' state to stdout #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
commented
Dec 10, 2021
| @@ -127,6 +128,32 @@ func (ctx TestContext) DumpNamespaceArtifacts(namespace string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (ctx TestContext) DescribeResource(command string) error { | |||
There was a problem hiding this comment.
This can be largely be useful to dump out resources (or container logs) when you run into a failed test case:
if CurrentGinkgoTestDescription().Failed {
ctx.Ctx().DescribeResource(fmt.Sprintf("kubectl get operators %s -o yaml", o.GetName()))
ctx.Ctx().DescribeResource(fmt.Sprintf("kubectl -n %s logs -l app=olm-operator --tail=50 --prefix --timestamps", *olmNamespace))
}
timflannagan
changed the title
|
I put the fix for the unit test failure in #2521 |
perdasilva
reviewed
Dec 16, 2021
|
/lgtm Nice, I like the approach here. |
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
18f1d3e to
4ff336e
Compare
|
New changes are detected. LGTM label has been removed. |
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
4ff336e to
a312e1d
Compare
|
/approve |
11 tasks
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
a312e1d to
f67d640
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
f67d640 to
070e43c
Compare
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
070e43c to
6735ffb
Compare
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
6735ffb to
e7f7d81
Compare
timflannagan
force-pushed
the
ci/add-resource-debugging-support
branch
from
b7d37f6 to
20f842c
Compare
Add initial support for debugging individual Kubernetes resources, executing arbitrary shell commands, etc. This is mainly useful in the context of debugging cluster-scoped resources (e.g. the Operator API) that don't necessary fit into the test/e2e/collect-ci-artifacts.sh gather script. Signed-off-by: timflannagan <[email protected]>
awgreene
force-pushed
the
ci/add-resource-debugging-support
branch
from
20f842c to
7b27540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for debugging individual Kubernetes resources,
executing arbitrary shell commands, etc. This is mainly useful in the
context of debugging cluster-scoped resources (e.g. the Operator API)
that don't necessary fit into the test/e2e/collect-ci-artifacts.sh
gather script.
Signed-off-by: timflannagan [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc