put mutex around installplan creation

[akihikokuroda]

Signed-off-by: akihikokuroda [email protected]

Description of the change:
This PR makes the check if the InstallPlan has to be created and the creation of the installplan in a locked block so that 2 namespace queue workers don't create the Installplan for the subscription.

Motivation for the change:

Closes #2544

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

[openshift-ci]

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

lgtm - it could be worth while to add some comments to explain why the lock is needed, maybe even reference the issue. Might help other people keep an eye on these types of race conditions, etc.

[perdasilva]

/lgtm

[akihikokuroda]

The e2e test failure is addressed in #2542.

[perdasilva]

@akihikokuroda could you please rebase

[perdasilva]

/lgtm

[perdasilva]

/ok-to-test

[timflannagan]

/lgtm

[awgreene]

/approve

[akihikokuroda]

/retest

[timflannagan]

@akihikokuroda Can you rebase this when you get a chance? I think this is ready to go.

[timflannagan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment