e2e - add Eventually for config injection check

[akihikokuroda]

Signed-off-by: akihikokuroda [email protected]

There is a timing gap between the operatorsv1alpha1.SubscriptionStateAtLatest being set in the subscription state and the configs are injected into the CSV.

Description of the change:
This PR adds an Eventually waiting for the config injection.

Motivation for the change:
Closes #2507

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

[openshift-ci]

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/ok-to-test

[timflannagan]

/lgtm

[timflannagan]

I had one more comment for moving any errors.New(fmt.Sprintf(...)) to simply fmt.Errorf(...) which would remove the errors package import as well (it looks like there are a couple of instances here). Otherwise, this looks ready to go imo.

[awgreene]

Great work on this.

[awgreene]

Non-blocking nit:

Suggested change

	err = check(&deployment.Spec.Template.Spec.Containers[i])
	if err != nil {
	return err
	}
	if err = check(&deployment.Spec.Template.Spec.Containers[i]); err != nil {
	return err
	}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[timflannagan]

/lgtm