Skip to content

doc/design: Update the release documentation #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Update release.md now that the repository uses goreleaser to
automatically produce draft releases for new tags.

Signed-off-by: timflannagan [email protected]

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from awgreene and hasbro17 January 5, 2022 21:41
@timflannagan timflannagan force-pushed the doc/update-release-documentation branch from 0818461 to d836025 Compare January 5, 2022 21:49
@perdasilva
Copy link
Collaborator

/approve

@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
# 0.11.0 is the bumped version.
git tag -a v0.18.0 -m "Version 0.18.0"
# v0.20.0 is the bumped version.
git tag -a v0.20.0 -m "Version 0.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily related to the scope of this PR, but... should we sign our tags? (with the --sign flag)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any opposition towards doing that. Might be worth bubbling that up to the rest of the team to see if there are any strong objections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for it.

Update release.md now that the repository uses goreleaser to
automatically produce draft releases for new tags.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the doc/update-release-documentation branch from d836025 to f097930 Compare January 6, 2022 14:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@timflannagan
Copy link
Member Author

rebased against master to make branch protection happy.

Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great work on this @timflannagan

@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@awgreene
Copy link
Member

awgreene commented Jan 6, 2022

Ah - the PR had already been approved by @perdasilva, adding an lgtm.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@timflannagan
Copy link
Member Author

Force merging as this PR only affects the release documentation and we don't need to continuously run the e2e-tests workflow to get a successful check for this be automatically merged.

@timflannagan timflannagan merged commit 5c4c67a into operator-framework:master Jan 6, 2022
@timflannagan timflannagan deleted the doc/update-release-documentation branch January 6, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants