Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump repository to Go 1.17 #2556

Merged

Conversation

timflannagan
Copy link
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from gallettilance and njhale January 7, 2022 16:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@timflannagan timflannagan force-pushed the bump-go-1.17 branch 2 times, most recently from b0c777e to 15df292 Compare January 7, 2022 16:36
@awgreene
Copy link
Member

awgreene commented Jan 7, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene
Copy link
Member

awgreene commented Jan 7, 2022

/retest

1 similar comment
@timflannagan
Copy link
Member Author

/retest

@awgreene
Copy link
Member

awgreene commented Jan 7, 2022

/lgtm

I forgot that Tim finally has approval permissions :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit ab8bb97 into operator-framework:master Jan 7, 2022
@timflannagan timflannagan deleted the bump-go-1.17 branch January 7, 2022 19:40
@timflannagan timflannagan mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants