tools.go: Fix build constraints error message for the k8s.io/code-generator dependency #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
force-pushed
the
cleanup/fix-tools-import-error-codegen
branch
from
993a65c to
d9b4cbd
Compare
|
The e2e error is probably fixed by #2554 |
timflannagan
force-pushed
the
cleanup/fix-tools-import-error-codegen
branch
from
22a3e78 to
d1e9c93
Compare
…erator dependency Update the k8s.io/code-generator dependency and explicitly specify which packages are needed in order to update codegen/mockgen, and silence the following error locally: ``` error while importing k8s.io/code-generator: build constraints exclude all Go files in ... ``` Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
…the vendor directory
timflannagan
force-pushed
the
cleanup/fix-tools-import-error-codegen
branch
from
d1e9c93 to
0c2c376
Compare
openshift-ci
bot
added
the
needs-rebase
|
@timflannagan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the k8s.io/code-generator dependency and explicitly specify which
packages are needed in order to update codegen/mockgen, and silence the
following error locally:
Signed-off-by: timflannagan [email protected]
Motivation for the change:
Cleanup: silence warning on local IDEs.
Reviewer Checklist
/doc