ci: Support configuring the logging level for the splitter package #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the split package and add support for configuring the logging level to avoid CI interpretting info-level logging as error messages. Signed-off-by: timflannagan <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
commented
Jan 21, 2022
| @@ -103,14 +112,14 @@ func findDescribes(dir string) ([]string, error) { | |||
| } | |||
| specNames := topDescribeRE.FindAllSubmatch(b, -1) | |||
| if len(specNames) == 0 { | |||
| log.Printf("%s: found no top level describes, skipping", match) | |||
| logger.Warnf("%s: found no top level describes, skipping", match) | |||
There was a problem hiding this comment.
Another implementation: we could also just remove logging from this package entirely. It's nice for debugging this package while developing locally, but provides little value when running in CI environments.
There was a problem hiding this comment.
If it's not getting in the way, I'd say leave it. Logging is helpful during development. Though a debugger is also nice...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the split package and add support for configuring the logging
level to avoid CI interpretting info-level logging as error messages.
Signed-off-by: timflannagan [email protected]
Description of the change:
Add support for configuring the logging level for the e2e splitter package, and default to the error level.
Motivation for the change:
This is to workaround CI interpreting the previous log.Print* calls as error-level messages. A concrete example can be found in this action run: https://github.com/operator-framework/operator-lifecycle-manager/actions/runs/1724759061 where "found no top level describes, skipping" has a red market above it.
Reviewer Checklist
/doc