add logo for github dark theme #2622

eliranmal · 2022-02-11T19:13:35Z

Description of the change:

in the repository's main readme file, support github's dark theme by adding a new image, and using the appropriate suffix for the image URLs.

here's a screenshot demonstrating the proposed solution, with the dark-dimmed theme:

… and another one, showing there's no regression with a light theme on:

Motivation for the change:

currently, when github users switch to dark mode, the logo text disappears into the background (to a certain extent, depending on the specific theme variant).

see screenshots of the current state in the reported issue (#2623).

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive

Closes: #2623

openshift-ci · 2022-02-11T19:13:44Z

Hi @eliranmal. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njhale · 2022-02-11T19:19:55Z

@eliranmal Wow, that's much better! Thank you for taking the time to help make the repo look more professional!

It looks like you've yet to sign off on the commit -- if you amend the --sign-off flag and push, we should be able to get this merged quickly.

/approve

eliranmal · 2022-02-11T19:28:30Z

thanx @njhale, that was quick!

yes, i was reading through the docs, and it just bugged me 😄

i did amend my (single) commit to contain the sign-off line, but i'll double check (maybe i pushed two separate commits, and one of them is faulty...).

support dark mode by adding a new image, and using the appropriate suffix for the image URL in markdown. Signed-off-by: eliran <[email protected]>

eliranmal · 2022-02-11T19:59:09Z

done! turns out my IDE messed it up :)

openshift-ci · 2022-02-11T20:04:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliranmal, njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhale,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

njhale · 2022-02-11T20:12:37Z

/lgtm

openshift-ci · 2022-02-12T00:57:11Z

@eliranmal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

logo-dark-mode.svg

openshift-bot · 2022-02-12T01:53:37Z

/retest-required