Clarify solver package responsibility. #2647
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc @timflannagan |
benluddy
force-pushed
the
installable-rename
branch
from
70555a4 to
7ac2ed2
Compare
| @@ -107,8 +107,8 @@ func (d *litMapping) ConstraintOf(m z.Lit) AppliedConstraint { | |||
| } | |||
| d.errs = append(d.errs, fmt.Errorf("no constraint corresponding to %s", m)) | |||
| return AppliedConstraint{ | |||
| Installable: zeroInstallable{}, | |||
| Constraint: zeroConstraint{}, | |||
| Variable: zeroVariable{}, | |||
| // Variable values are the basic unit of problems and solutions | ||
| // understood by this package. |
There was a problem hiding this comment.
Any value in beefing up this godoc comment to tie it back to the CSP?
There was a problem hiding this comment.
Added a package-level summary that addresses this, PTAL.
|
Thanks - I think this is a step in the right direction, as variables like |
As part of preparing the resolution component (and subcomponents) for use as a library, this clarifies the responsibility of the solver package as a general-purpose boolean constraint satisfiability solver. Renaming the Variable type -- formerly Installable -- avoids unnecessarily tying it to the resolver package's operator installability use case. The solver package finds solutions to constraint satisfaction problems in general. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
installable-rename
branch
from
7ac2ed2 to
22edf0e
Compare
benluddy
changed the title
|
/lgtm |
As part of preparing the resolution component (and subcomponents) for
use as a library, this clarifies the responsibility of the solver
package as a general-purpose boolean constraint satisfiability solver.
Renaming the Variable type -- formerly Installable -- avoids
unnecessarily tying it to the resolver package's operator
installability use case. The solver package finds solutions to
constraint satisfaction problems in general.