-
Notifications
You must be signed in to change notification settings - Fork 552
Remove generated and unused resolver/fakes subpackage. #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generated and unused resolver/fakes subpackage. #2649
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2fd2d9c
to
908a635
Compare
/lgtm |
Let's get #2625 merged first. /hold |
908a635
to
8630199
Compare
/hold cancel |
Is this linter broken for commits that have fewer packages than their parent did? |
I'm not entirely sure why we're seeing golangci-lint consistently timeout here. That might be the first time I've seen that check time out since it was integrated. The timeout value is hardcoded to 5m so maybe bumping to 6m might help? |
This has to be a bug in the GH action, especially since it's happening during "package loading" and this PR does nothing besides delete a package. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Ben Luddy <[email protected]>
8630199
to
9937b24
Compare
New changes are detected. LGTM label has been removed. |
The go:generate comment that produces this was removed in 9b537bf, and nothing appears to be using it.