Skip to content

Remove generated and unused resolver/fakes subpackage. #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

benluddy
Copy link
Contributor

The go:generate comment that produces this was removed in 9b537bf, and nothing appears to be using it.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@benluddy benluddy force-pushed the remove-resolver-fakes branch from 2fd2d9c to 908a635 Compare February 16, 2022 15:34
@njhale
Copy link
Member

njhale commented Feb 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@timflannagan
Copy link
Member

Let's get #2625 merged first.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2022
@benluddy benluddy force-pushed the remove-resolver-fakes branch from 908a635 to 8630199 Compare February 16, 2022 16:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@timflannagan
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@benluddy
Copy link
Contributor Author

Is this linter broken for commits that have fewer packages than their parent did?

@timflannagan
Copy link
Member

Is this linter broken for commits that have fewer packages than their parent did?

I'm not entirely sure why we're seeing golangci-lint consistently timeout here. That might be the first time I've seen that check time out since it was integrated. The timeout value is hardcoded to 5m so maybe bumping to 6m might help?

@benluddy
Copy link
Contributor Author

This has to be a bug in the GH action, especially since it's happening during "package loading" and this PR does nothing besides delete a package.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@benluddy benluddy added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@benluddy benluddy merged commit 446db0c into operator-framework:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants