Remove ConstraintProvider from the exported solver package API. #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface is a resolver package concern, so its definition can live beside the code that accepts it. Removing it from solver also removes the only solver->cache package dependency. As I understand it, the only way to inject an implementation of this interface today is by having access to unexported fields of resolver.Resolver, so for now I've also made the interface unexported. In the context of the ongoing desire to support resolution as a separate library module, this will allow more time to evaluate the shape of a stable library API. Signed-off-by: Ben Luddy <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
njhale
reviewed
Feb 24, 2022
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface is a resolver package concern, so its definition can
live beside the code that accepts it. Removing it from solver also
removes the only solver->cache package dependency.
As I understand it, the only way to inject an implementation of this
interface today is by having access to unexported fields of
resolver.Resolver, so for now I've also made the interface
unexported. In the context of the ongoing desire to support resolution
as a separate library module, this will allow more time to evaluate
the shape of a stable library API.