Move metrics e2e to one namespace per spec

[perdasilva]

Signed-off-by: perdasilva [email protected]

Description of the change:
This PR moves the metrics e2e to one namespace per spec

Motivation for the change:
CI stability

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky
• Tests that remove the [FLAKE] tag are no longer flaky

[timflannagan]

Is this BeforeEach that's nested in the first Context container (lines 53-55) still relevant now:

		BeforeEach(func() {
			By("using the default OperatorGroup created in BeforeSuite")
		})

[timflannagan]

It looks like there's a test case that creates a failing CSV without an explicit metadata.Namespace but I think that's fine as the test case does properly cleanup that CSV afterwards.

Ran this locally and didn't see any obvious resource leakage:

$ gh pr checkout 2716
$ kind create cluster ; make run-local
$ make e2e E2E_INSTALL_NS=olm TEST="Metrics are generated for OLM managed resources" 
$  k get ns
NAME                 STATUS   AGE
default              Active   10m
kube-node-lease      Active   11m
kube-public          Active   11m
kube-system          Active   11m
local-path-storage   Active   10m
olm                  Active   9m14s
operators            Active   9m14s
$ k get crds
NAME                                          CREATED AT
catalogsources.operators.coreos.com           2022-03-28T15:34:48Z
clusterserviceversions.operators.coreos.com   2022-03-28T15:34:48Z
installplans.operators.coreos.com             2022-03-28T15:34:50Z
olmconfigs.operators.coreos.com               2022-03-28T15:34:51Z
operatorconditions.operators.coreos.com       2022-03-28T15:34:52Z
operatorgroups.operators.coreos.com           2022-03-28T15:34:52Z
operators.operators.coreos.com                2022-03-28T15:34:54Z
subscriptions.operators.coreos.com            2022-03-28T15:34:55Z
$ k get operators
NAME                      AGE
myapp.metrics-e2e-29wqp   4m16s
myapp.metrics-e2e-7bnpt   4m17s
myapp.metrics-e2e-gtpjc   4m17s
myapp.metrics-e2e-jnzfz   4m17s
myapp.metrics-e2e-t7blg   4m15s

[timflannagan]

Holding in case we need a second reviewer. Feel free to remove the hold.

/lgtm
/hold

[perdasilva]

/lgtm

[openshift-ci]

@perdasilva: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/lgtm
/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [perdasilva,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment