Move user defined service account e2e to one namespace per spec #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
refactor_user_defined_e2e
branch
8 times, most recently
from
0701465 to
5622d43
Compare
Signed-off-by: perdasilva <[email protected]>
perdasilva
force-pushed
the
refactor_user_defined_e2e
branch
from
5622d43 to
11535dc
Compare
timflannagan
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
The code changes lgtm and I pulled this down locally and ran the user-defined SA suite in isolation five times and all runs ended up passing. I didn't notice any namespace-level leakage which is nice, but there's a good chunk of cluster-scoped leakage that doesn't appear to effect the test cases themsevles:
$ k get crds --sort-by '.metadata.creationTimestamp'
...
insfw7fx.cluster.com 2022-03-30T15:31:48Z
inskksxb.cluster.com 2022-03-30T15:33:18Z
insrhw6v.cluster.com 2022-03-30T15:40:27Z
inshwndx.cluster.com 2022-03-30T15:41:57Z
ins6s2vn.cluster.com 2022-03-30T15:43:52Z
insxch24.cluster.com 2022-03-30T15:45:22Z
inskztgv.cluster.com 2022-03-30T15:49:49Z
insqzzmd.cluster.com 2022-03-30T15:51:17Z
insgj5fk.cluster.com 2022-03-30T15:53:39Z
insrfk9j.cluster.com 2022-03-30T15:55:09Z
insh482m.cluster.com 2022-03-30T15:57:17Z
insv4lqb.cluster.com 2022-03-30T15:58:44Z
$ k get clusterroles --sort-by '.metadata.creationTimestamp'
...
insfw7fx.cluster.com-v1alpha1-admin 2022-03-30T15:31:52Z
insfw7fx.cluster.com-v1alpha1-view 2022-03-30T15:31:52Z
insfw7fx.cluster.com-v1alpha1-edit 2022-03-30T15:31:52Z
insfw7fx.cluster.com-v1alpha1-crdview 2022-03-30T15:31:52Z
inskksxb.cluster.com-v1alpha1-crdview 2022-03-30T15:33:23Z
inskksxb.cluster.com-v1alpha1-admin 2022-03-30T15:33:23Z
inskksxb.cluster.com-v1alpha1-edit 2022-03-30T15:33:23Z
inskksxb.cluster.com-v1alpha1-view 2022-03-30T15:33:23Z
insrhw6v.cluster.com-v1alpha1-view 2022-03-30T15:40:32Z
insrhw6v.cluster.com-v1alpha1-admin 2022-03-30T15:40:32Z
insrhw6v.cluster.com-v1alpha1-crdview 2022-03-30T15:40:32Z
insrhw6v.cluster.com-v1alpha1-edit 2022-03-30T15:40:32Z
inshwndx.cluster.com-v1alpha1-view 2022-03-30T15:42:02Z
inshwndx.cluster.com-v1alpha1-admin 2022-03-30T15:42:02Z
inshwndx.cluster.com-v1alpha1-edit 2022-03-30T15:42:02Z
inshwndx.cluster.com-v1alpha1-crdview 2022-03-30T15:42:02Z
ins6s2vn.cluster.com-v1alpha1-admin 2022-03-30T15:43:57Z
ins6s2vn.cluster.com-v1alpha1-crdview 2022-03-30T15:43:58Z
ins6s2vn.cluster.com-v1alpha1-edit 2022-03-30T15:43:58Z
ins6s2vn.cluster.com-v1alpha1-view 2022-03-30T15:43:58Z
insxch24.cluster.com-v1alpha1-admin 2022-03-30T15:45:27Z
insxch24.cluster.com-v1alpha1-edit 2022-03-30T15:45:27Z
insxch24.cluster.com-v1alpha1-crdview 2022-03-30T15:45:27Z
insxch24.cluster.com-v1alpha1-view 2022-03-30T15:45:27Z
inskztgv.cluster.com-v1alpha1-crdview 2022-03-30T15:49:54Z
inskztgv.cluster.com-v1alpha1-edit 2022-03-30T15:49:54Z
inskztgv.cluster.com-v1alpha1-view 2022-03-30T15:49:54Z
inskztgv.cluster.com-v1alpha1-admin 2022-03-30T15:49:54Z
insgj5fk.cluster.com-v1alpha1-edit 2022-03-30T15:53:44Z
insgj5fk.cluster.com-v1alpha1-crdview 2022-03-30T15:53:44Z
insgj5fk.cluster.com-v1alpha1-view 2022-03-30T15:53:44Z
insgj5fk.cluster.com-v1alpha1-admin 2022-03-30T15:53:44Z
insrfk9j.cluster.com-v1alpha1-edit 2022-03-30T15:55:13Z
insrfk9j.cluster.com-v1alpha1-view 2022-03-30T15:55:13Z
insrfk9j.cluster.com-v1alpha1-admin 2022-03-30T15:55:13Z
insrfk9j.cluster.com-v1alpha1-crdview 2022-03-30T15:55:13Z
insh482m.cluster.com-v1alpha1-edit 2022-03-30T15:57:24Z
insh482m.cluster.com-v1alpha1-admin 2022-03-30T15:57:24Z
insh482m.cluster.com-v1alpha1-crdview 2022-03-30T15:57:24Z
insh482m.cluster.com-v1alpha1-view 2022-03-30T15:57:24Z
insv4lqb.cluster.com-v1alpha1-admin 2022-03-30T15:58:48Z
insv4lqb.cluster.com-v1alpha1-edit 2022-03-30T15:58:48Z
insv4lqb.cluster.com-v1alpha1-view 2022-03-30T15:58:49Z
insv4lqb.cluster.com-v1alpha1-crdview 2022-03-30T15:58:49Z/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: perdasilva [email protected]
Description of the change:
This PR moves the service account e2e to one namespace per spec it also adds options to the test namespace creation to support different operator groups in a more friendly way
NOTE: Probably better to merge this one last and update all the other e2e tests on the rebase?
Motivation for the change:
CI stability
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky