Refactor webhook e2e #2718
Refactor webhook e2e #2718
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
refactor_webhook_e2e
branch
8 times, most recently
from
2e367e4 to
7e7d876
Compare
| @@ -8,6 +8,7 @@ import ( | |||
|
|
|||
| . "github.com/onsi/ginkgo" | |||
| . "github.com/onsi/gomega" | |||
| "github.com/operator-framework/operator-lifecycle-manager/test/e2e/ctx" | |||
There was a problem hiding this comment.
nit: package import ordering (blocking?) compared to the rest of the OLM packages listed.
| "foo": "bar", | ||
| } | ||
| namespace = &corev1.Namespace{ | ||
| generatedNamespace = corev1.Namespace{ |
There was a problem hiding this comment.
Any idea whether we can add support for injecting labels into the testing namespace generation helper function?
There was a problem hiding this comment.
With my options support! XDDD
Signed-off-by: perdasilva <[email protected]>
perdasilva
force-pushed
the
refactor_webhook_e2e
branch
from
7e7d876 to
0a9308e
Compare
|
I pulled these changes down locally and didn't see any clear resource leakage so these changes look ready to go to me. /lgtm |
Description of the change:
This PR moves the webhook e2e suite to one namespace per spec
Motivation for the change:
CI stability
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky