Skip to content

(e2e) Reduce Consistently time for catalogsource_ready metrics check #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

(e2e) Reduce Consistently time for catalogsource_ready metrics check #2739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/metrics_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
AfterEach(func() {
cleanup()
})
It("emits metrics for the catalogSource", func() {
It("emits catalogsource_ready metric for the catalogSource with Value equal to 1", func() {
Eventually(func() []Metric {
return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"))
}).Should(And(
Expand Down Expand Up @@ -412,7 +412,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
AfterEach(func() {
cleanup()
})
It("emits metrics for the CatlogSource with a Value greater than 0", func() {
It("emits metrics for the CatlogSource with a Value equal to 0", func() {
Eventually(func() []Metric {
return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"))
}).Should(And(
Expand All @@ -425,7 +425,7 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
))
Consistently(func() []Metric {
return getMetricsFromPod(c, getPodWithLabel(c, "app=catalog-operator"))
}, "3m").Should(And(
}, "1m", "30s").Should(And(
ContainElement(LikeMetric(
WithFamily("catalogsource_ready"),
WithName(name),
Expand Down