e2e: Add support for overriding the kubectl binary when gather artifacts #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
force-pushed
the
ci/add-support-for-overriding-kubectl-binary
branch
from
8b75703 to
89676c3
Compare
timflannagan
commented
Apr 14, 2022
| @@ -7,7 +7,10 @@ set -o errexit | |||
| : "${KUBECONFIG:?}" | |||
| : "${TEST_NAMESPACE:?}" | |||
| : "${TEST_ARTIFACTS_DIR:?}" | |||
| : "${KUBECTL:=kubectl}" | |||
There was a problem hiding this comment.
Note: this KUBECTL variable defaults to kubectl when it hasn't been defined/overridden locally. This change now allows users to override this variable in their local/CI environments, e.g. make e2e KUBECTL=oc.
njhale
reviewed
Apr 18, 2022
timflannagan
force-pushed
the
ci/add-support-for-overriding-kubectl-binary
branch
2 times, most recently
from
6030b7a to
b21e5dc
Compare
Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
ci/add-support-for-overriding-kubectl-binary
branch
from
b21e5dc to
fab13a7
Compare
|
/lgtm |
perdasilva
pushed a commit
to perdasilva/operator-lifecycle-manager
that referenced
this pull request
Apr 27, 2022
…cts (operator-framework#2741) Signed-off-by: timflannagan <[email protected]> Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: timflannagan [email protected]
Description of the change:
Add support for overriding the kubectl binary that's responsible for gathering namespace-scoped test artifacts when individual test cases fail.
Motivation for the change:
Avoid hardcoding the kubectl binary location when kubectl isn't present in a users/CI environment's $PATH.
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky