Address fail forward unit test failures #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The broken replacement chain unit test occasionally fails because it is possible for either the a.v1 or a.v2 operators to cause the resolver to fail. This commit updates the test to check that the resolver fails because a csv is in the failed state versus checking that a specific csv is in the failed state. Signed-off-by: Alexander Greene <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broken replacement chain unit test occasionally fails because it is
possible for either the a.v1 or a.v2 operators to cause the resolver to
fail. This commit updates the test to check that the resolver fails
because a csv is in the failed state versus checking that a specific
csv is in the failed state.
Signed-off-by: Alexander Greene [email protected]