Remove operatorgroup queueinformer #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exdx
changed the title
awgreene
reviewed
Apr 28, 2022
|
/lgtm |
|
The commit message is a bit off eh? We should probably just mention that we no longer:
|
Yeah I think it's probably overly-verbose. I will fix it up. |
|
/approve |
openshift-ci
bot
added
the
approved
|
/hold Commit has @exdx's signature as its header. |
openshift-ci
bot
added
the
do-not-merge/hold
exdx
force-pushed
the
fix/og-syncer
branch
2 times, most recently
from
af29d9c to
e032d48
Compare
|
Fixed! Sorry about that. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
timflannagan
approved these changes
Apr 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, exdx, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes the unneccesary operatorgroup queueinformer, since only an operatorgroup lister is needed. Also ensures that the syncResolvingNamespace function is no longer triggered by operatorgroup events. Signed-off-by: Daniel Sover <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
An operatorgroup queueinformer was introduced in #2728.
The operatorgroup syncer was calling the syncResolvingNamespace
function, which expects a namespace object as an argument, with an
operatorgroup instead. This led to casting errors.
Since there is no need for an operatorgroup queueinformer, only a lister, the queueinformer can be removed entirely.
Motivation for the change:
Downstream bug
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky