Refactor installer to surface certificate rotation #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
fix_cert_rotation_test
branch
3 times, most recently
from
9c44cf5 to
03225f0
Compare
Signed-off-by: perdasilva <[email protected]>
perdasilva
force-pushed
the
fix_cert_rotation_test
branch
from
03225f0 to
b6c206a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
perdasilva
added a commit
to perdasilva/operator-lifecycle-manager
that referenced
this pull request
May 23, 2022
…k#2775) Signed-off-by: perdasilva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: perdasilva [email protected]
Description of the change:
Refactors the installer interface to surface certificate rotation, fixing the issue where were calculating the rotation time twice, independently, in different places. This is more robust and will signal the certificate has rotated for any reason (missing pod, or other resource).
Motivation for the change:
Closes: #2773 #2764
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky