Revert "chore: update o-f/api dependency to v0.17 (#2848)" #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
approved these changes
Sep 13, 2022
openshift-ci
bot
added
the
approved
|
Can we include the justification/reasoning behind the revert in the commit message? |
…#2848)" This reverts commit bd97e32. An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig field](operator-framework/api#261). Reverting operator-framework#2848 so that the new v0.17.0 can be pulled in. See [this comment](operator-framework#2848 (comment)) for more info. Signed-off-by: Anik Bhattacharjee <[email protected]>
anik120
force-pushed
the
revert-tylers-v0.17-api
branch
from
0daa362 to
108e1ae
Compare
|
@dinhxuanvu done. |
|
/approve cancel |
openshift-ci
bot
removed
the
approved
|
Has this change made it to downstream? |
|
No it did not |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
🤞🏻 /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bd97e32.
An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field. Reverting #2848 so that
the new v0.17.0 can be pulled in. See this comment for more info.
Signed-off-by: Anik Bhattacharjee [email protected]
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue