Workaround server-side apply not working

[sathieu]

Description of the change:

Explicitly set container port protocol to TCP.

NB: This should have been fixed already while upgrading to k8s 1.20 (see kubernetes/kubernetes#92332 and probably kubernetes/kubernetes@d3e641e). Is there some tooling issue?

Motivation for the change:

Fixes:

error calculating structured merge diff:
error building typed value from config resource:
.spec.install.spec.deployments[0].spec.template.spec.containers[0].ports: element 0: associative list with keys has an element that omits key field "protocol" (and doesn't have default value)

Architectural changes:

Testing remarks:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Bug fixes are accompanied by regression test(s)
• e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
• tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
• Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky and have an issue
• Code is properly formatted

[openshift-ci]

Hi @sathieu. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

@sathieu I've rebased your PR from this side

[perdasilva]

/ok-to-test

[perdasilva]

/lgtm

[sathieu]

@perdasilva Thanks for your review. What can I do to move this forward?

[sathieu]

@akihikokuroda @ecordell COuld you please review this one-ine PR?

[perdasilva]

lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/lgtm

[sathieu]

Thanks @perdasilva 🙏 !