Helm upgrade to v3.11.1 for CVE-2023-25165 #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Updatate go.mod, go.sum, and vendor directory. Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
helm-upgrade
branch
4 times, most recently
from
55c50bc to
2ffe592
Compare
Plus some manual edits. Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Status is now updated using SubResource methods and options Signed-off-by: Todd Short <[email protected]>
tmshort
changed the title
openshift-ci-robot
added
jira/severity-low
tmshort
changed the title
openshift-ci-robot
removed
jira/severity-low
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
m1kola
approved these changes
Mar 10, 2023
Comment on lines
90
to
+97
| // plan := &InstallPlan{} | ||
| // plan.SetNamespace("ns") | ||
| // plan.SetName("install-123def") | ||
| // Eventually(c.Apply(plan, func(p *v1alpha1.InstallPlan) error { | ||
| // p.Spec.Approved = true | ||
| // return nil | ||
| // })).Should(Succeed()) | ||
| // | ||
| // Eventually(c.Apply(plan, func(p *v1alpha1.InstallPlan) error { | ||
| // p.Spec.Approved = true | ||
| // return nil | ||
| // })).Should(Succeed()) |
There was a problem hiding this comment.
Might want to make the whole code block indented. See Go Doc Comments: Code blocks.
// plan := &InstallPlan{}
// plan.SetNamespace("ns")
// plan.SetName("install-123def")
// Eventually(c.Apply(plan, func(p *v1alpha1.InstallPlan) error {
// p.Spec.Approved = true
// return nil
// })).Should(Succeed())There was a problem hiding this comment.
True. go fmt ./... did that particular change; not me! :)
There was a problem hiding this comment.
I know. go fmt makes assumptions and changes stuff, but not intelegent and breaks code blocks sometimes.
go fmt will be happy with the formatting I suggested.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, awgreene, m1kola, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update helm to v3.11.1, this necessitates additional upgrades (e.g. to kube 1.26 APIs).
Motivation for the change:
CVE-2023-25165
Architectural changes:
None.
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue