Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes godoc rendering #2937

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Mar 14, 2023

Follow up for https://github.com/operator-framework/operator-lifecycle-manager/pull/2933/files#r1132142964

Before:
Screenshot 2023-03-14 at 14 31 45

After:
Screenshot 2023-03-14 at 14 31 35

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@m1kola
Copy link
Member Author

m1kola commented Mar 14, 2023

/cc tmshort

@openshift-ci openshift-ci bot requested a review from tmshort March 14, 2023 14:36
@tmshort
Copy link
Contributor

tmshort commented Mar 14, 2023

It's a comment. As long as go fmt ./... doesn't try to undo it...
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola, perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m1kola looks like this needs a rebase.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023
@m1kola
Copy link
Member Author

m1kola commented Mar 23, 2023

Rebased. Please take another look

@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@m1kola
Copy link
Member Author

m1kola commented Apr 11, 2023

@perdasilva I had to rebase becaues github check was complaining that the branch is out of date. Could you please lgtm again? Nothing changed apart from rebase.

@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@perdasilva perdasilva merged commit a538741 into operator-framework:master Apr 12, 2023
@m1kola m1kola deleted the godoc_fix branch April 12, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants