-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog source affinity #2963
Catalog source affinity #2963
Conversation
Hi @Jamstah. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Opened as a draft, partly to let the tests run, and partly to ask a question. The API change hasn't been put into a release yet - is that something I should wait for before finalizing the PR? |
ffba91e
to
0a7c65d
Compare
/ok-to-test |
Hi @Jamstah - thanks heaps for this ^^ |
Great. LMK when that's happened and I can rebase and revendor. |
Signed-off-by: James Hewitt <[email protected]>
Signed-off-by: James Hewitt <[email protected]>
0a7c65d
to
5c92d9d
Compare
OK, should be all done. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jamstah, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Add affinity customization to catalog sources
Closes #2960
Motivation for the change:
Enable multi-architecture catalog images to limit scheduling to their supported architectures.
Architectural changes:
n/a
Testing remarks:
Basically a copy paste of the same thing for tolerations.
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue