Fix Image Update test #3093
Merged
Fix Image Update test #3093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
This change grants the serviceAccount used by the catalogSource permissions to pull from the internal registry. Signed-off-by: Alexander Greene <[email protected]>
awgreene
force-pushed
the
fix-image-update-test
branch
from
b427cfc to
c8bbcc0
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel We can sleuth out-of-band by running a build with this commit removed :) |
openshift-ci
bot
removed
the
do-not-merge/hold
|
I've created #3094 to add context to @stevekuznetsov's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change grants the serviceAccount used by the catalogSource permissions to pull from the internal registry.