ClusterRoleBindings and Services Installation: SSA #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
dtfranz
force-pushed
the
crb-service-ssa
branch
2 times, most recently
from
1410b4a to
afe74f9
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dtfranz
force-pushed
the
crb-service-ssa
branch
from
afe74f9 to
d6b4760
Compare
… SSA in order to avoid race conditions. Signed-off-by: Daniel Franz <[email protected]>
dtfranz
force-pushed
the
crb-service-ssa
branch
from
d6b4760 to
7ecf512
Compare
Merged
via the queue into
operator-framework:master
with commit Feb 28, 2024
dc0c564
15 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify installation steps for ClusterRoleBindings and Services to use SSA in order to avoid race conditions.
In draft until I fix a failing unit test.Fake Client and envtest do not currently support SSA, but creating the objects beforehand functions as a workaround for now. I've left comments in the PR pointing out areas where I've used this.