copy-content: delete destination dirs before copying #3197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the copy-content binary to always delete the destination directories to ensure they contain no extraneous content
Motivation for the change:
If a catalog pod using
extractContent
mode is restarted after the underlying catalog image changes (e.g. if a cluster is shutdown and the catalog is updated in the meantime), the copy-content init container re-runs and does not clear out the existing contents of the emptyDir, which causes theopm serve
container to fail due to a mismatched digest.Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue