Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-content: delete destination dirs before copying #3197

Merged

Conversation

joelanford
Copy link
Member

Description of the change:
Update the copy-content binary to always delete the destination directories to ensure they contain no extraneous content

Motivation for the change:
If a catalog pod using extractContent mode is restarted after the underlying catalog image changes (e.g. if a cluster is shutdown and the catalog is updated in the meantime), the copy-content init container re-runs and does not clear out the existing contents of the emptyDir, which causes the opm serve container to fail due to a mismatched digest.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from awgreene and kevinrizza April 2, 2024 21:44
@grokspawn
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@joelanford joelanford added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@kevinrizza kevinrizza added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@grokspawn grokspawn added this pull request to the merge queue Apr 3, 2024
Merged via the queue into operator-framework:master with commit 3ed3c63 Apr 3, 2024
14 checks passed
@joelanford joelanford deleted the clear-extracted-catalog-dir branch October 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants