Skip to content

OCPBUGS-28230: fallback to logs for termination message #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

OCPBUGS-28230: fallback to logs for termination message #3203

merged 1 commit into from
Apr 12, 2024

Conversation

joelanford
Copy link
Member

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from dinhxuanvu and grokspawn April 12, 2024 18:57
@joelanford joelanford force-pushed the termination-message-policy branch from 75b2aa6 to a1331ae Compare April 12, 2024 19:31
@kevinrizza kevinrizza added this pull request to the merge queue Apr 12, 2024
Merged via the queue into operator-framework:master with commit 8434d3c Apr 12, 2024
14 checks passed
@joelanford joelanford deleted the termination-message-policy branch October 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelanford @kevinrizza